This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Image comparison: disable largeImageThreshold#171
Open
danielbeardsley wants to merge 3 commits intowebdriverio-boneyard:masterfrom
Open
Image comparison: disable largeImageThreshold#171danielbeardsley wants to merge 3 commits intowebdriverio-boneyard:masterfrom
danielbeardsley wants to merge 3 commits intowebdriverio-boneyard:masterfrom
Conversation
This "feature" makes the output nearly unusable and ironically significantly larger (at the benefit of saving ~20% of runtime) Set the number high enough that we'll never hit it. We had to bump node-resemble versions, but this hasn't changed the api at all.
danielbeardsley
force-pushed
the
large-image-threshold--disable
branch
from
7fb9c45 to
0a88c3e
Compare
It's called outputSettings, not outputOptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This "feature" makes the output nearly unusable and ironically
significantly larger (in filesize) at the benefit of saving ~20% of runtime
Set the threshold to 0 so it's turned off.
Before:
After:
