This repository was archived by the owner on Dec 18, 2019. It is now read-only.
Assorted fixes for small bugs in master#154
Open
diosmosis wants to merge 7 commits intowebdriverio-boneyard:masterfrom
Open
Assorted fixes for small bugs in master#154diosmosis wants to merge 7 commits intowebdriverio-boneyard:masterfrom
diosmosis wants to merge 7 commits intowebdriverio-boneyard:masterfrom
Conversation
added 7 commits
May 30, 2016 15:31
…rm (in babel 6, the blacklist .babelrc property is no longer supported).
…e files babel outputted if files were already built (resulting in error). Also process all files in the lib folder, not just the top level files.
…bdrivercss.js was importing it as).
…erio since it will end up including the ES6 code, not the compiled code in webdriverio/build.
…ed to exist by workflow.js and other files.
…sts' afterHook function.
…return a promise & checking properties in plugin.options instead of plugin.
Author
|
@christian-bromann don't want to create any noise or be annoying, but I'd be interested in helping to get webdrivercss compatible w/ webdriver.io 4. Would it be possible for me to get involved in that effort? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to see if I could get webdrivercss to work w/ the latest webdriverio. Then I realized a rewrite of webdrivercss is currently in progress, and the work was probably more than I could do in a couple of hours.
I managed to find and fix a couple bugs, though, while trying to get the instantiation.js test to pass. I figured they might be useful, so I created this PR.
Changes included:
loadTasks('build')call would cause grunt to try and load tasks from the build directory. If the compiled files are in build, this causes grunt to fail.lib/.../ErrorHandlersince this will try and load webdriverio's ES6 JS instead of the compiled JS.applitoolskey inDEFAULT_PROPERTIESsince many files expect it to be there (eg, workflow.js).afterHookin bootstrap.js, don't pass a callback to browser.end() since it returns a promise now.If the PR requires some changes, let me know.