Skip to content

Include actual JSON in assertion failure message #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmartelli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Include actual JSON in assertion failure message #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/uk/org/webcompere/modelassert/json/assertjson/AssertJson.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public AssertJson<T> satisfies(Condition condition) {
Result result = condition.test(converted);
if (!result.isPassed()) {
throw new AssertionFailedError("Expected: " + condition.describe() +
"\n but: " + result.getCondition() + " was " + result.getWas(),
"\n but:\n" + converted.toPrettyString() + "\nwas " + result.getWas(),
result.getCondition(), result.getWas());
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/uk/org/webcompere/modelassert/json/JsonAssertionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ void jsonAtWithAssertJson() {
void jsonAtWithAssertJsonNegative() {
assertThatThrownBy(() -> assertJson("{\"name\":\"Bill\"}").at("/name").hasValue("Not Bill"))
.isInstanceOf(Error.class)
.hasMessage("Expected: Path at /name is equal to Not Bill\n but: /name is equal to Not Bill was \"Bill\"");
.hasMessage("Expected: Path at /name is equal to Not Bill\n but:\n{\n \"name\" : \"Bill\"\n}\nwas \"Bill\"");
}

@Test
Expand All @@ -81,7 +81,7 @@ void jsonAtMultiWithAssertJsonNegative() {
.at("/name").hasValue("Bill")
.at("/age").hasValue(12))
.isInstanceOf(Error.class)
.hasMessage("Expected: Path at /age is equal to 12\n but: /age is equal to 12 was 42");
.hasMessage("Expected: Path at /age is equal to 12\n but:\n{\n \"name\" : \"Bill\",\n \"age\" : 42\n}\nwas 42");
}

@Test
Expand Down