-
Notifications
You must be signed in to change notification settings - Fork 122
fix: UI functionality repair #1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
juanlou1217
commented
Feb 9, 2026
- 添加 Mega Logo 组织图标组件
- 移除开发环境标识(DEV 红框)
- 精简用户菜单:删除 Support 和 Apps & integrations 选项
- 移除组织切换器中的 "New Organization" 按钮
- 添加 Mega Logo 组织图标组件 - 移除开发环境标识(DEV 红框) - 精简用户菜单:删除 Support 和 Apps & integrations 选项 - 移除组织切换器中的 "New Organization" 按钮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Moon web UI/navigation to better match the desired product surface by introducing a Mega organization logo icon and removing several development- or onboarding-oriented UI affordances.
Changes:
- Add
MegaLogoIconto the shared UI icon set and render it for the Mega organization in the org switcher. - Remove the dev-mode banner from the authenticated app provider layout.
- Simplify navigation menus by removing “Support”, “Apps & integrations”, and the “New organization” entry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| moon/packages/ui/src/Icons/index.tsx | Adds a new MegaLogoIcon SVG icon to the UI icon library. |
| moon/apps/web/components/Providers/AuthAppProviders.tsx | Removes DevModeBanner from the app-wide authenticated provider tree. |
| moon/apps/web/components/NavigationSidebar/ProfileDropdown.tsx | Removes several profile dropdown items (currently via commented-out blocks). |
| moon/apps/web/components/NavigationSidebar/OrganizationSwitcher.tsx | Removes “New organization” menu entry (currently via commented-out block) and conditionally shows MegaLogoIcon as the org avatar. |
Comments suppressed due to low confidence (1)
moon/apps/web/components/NavigationSidebar/ProfileDropdown.tsx:166
isStaff && { type: 'separator' }will currently produce two consecutive separators for staff users because there is already an unconditional separator earlier intopBarItems, andbuildMenuItemsonly filters truthy values (it doesn’t collapse/trim separators). Consider removing this staff-only separator or only inserting separators when there is a real item boundary.
isStaff && { type: 'separator' },
{
type: 'item',
label: 'Sign out',
leftSlot: <LogOutIcon />,
onSelect: () => signout.mutate(),
| // import { isMobile } from 'react-device-detect' | ||
| // import { SITE_URL } from '@gitmono/config' | ||
| // import { useIsDesktopApp } from '@gitmono/ui/src/hooks' | ||
|
|
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large blocks of commented-out imports/menu items were left in place. This makes the file harder to read and can become stale quickly; prefer deleting the unused code (or gating it behind a feature flag) instead of commenting it out.
| name={organization?.name} | ||
| urls={organization?.avatar_urls} | ||
| /> | ||
| organization?.name === 'Mega' ? ( |
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Mega logo avatar switch is keyed off organization.name === 'Mega', which is brittle (names can change, be localized, or differ in casing). Use a stable identifier such as organization.slug === 'mega' (or a shared constant from config) to decide when to render MegaLogoIcon.
| organization?.name === 'Mega' ? ( | |
| organization?.slug === 'mega' ? ( |
| ...(!isLg ? mobileItems : []) | ||
| // (!isLg || memberships?.length === 1) && { | ||
| // type: 'item', | ||
| // leftSlot: <PlusIcon />, | ||
| // label: 'New organization', | ||
| // url: '/new' | ||
| // } |
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is commented-out menu-item code left inside the allItems array (and commented icon imports above). Prefer removing the dead code entirely to avoid confusion and keep the menu definition clean.
| import { AutoTimezoneSwitcher } from '@/components/AutoTimezoneSwitcher' | ||
| import { IncomingCallRoomInvitationToast } from '@/components/Call/IncomingCallRoomInvitationToast' | ||
| import { LocalCommandMenu } from '@/components/CommandMenu' | ||
| import { FeedbackDialog } from '@/components/Feedback/FeedbackDialog' | ||
| import { GlobalKeyboardShortcuts } from '@/components/GlobalKeyboardShortcuts' | ||
| import { DevModeBanner } from '@/components/NavigationSidebar/DevModeBanner' | ||
| import { PostComposer } from '@/components/PostComposer' | ||
| import { AuthProvider } from '@/components/Providers/AuthProvider' |
Copilot
AI
Feb 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing DevModeBanner from the provider tree, the DevModeBanner component appears to be unused across the web app. Consider deleting components/NavigationSidebar/DevModeBanner.tsx (or otherwise referencing it) to avoid shipping dead code.
884de55