Conversation
WIP - switch to an sqs lib that polls for new messages concurrently rather than in batches - rewrite pickup worker so we can compose it out of single-responsibilty pieces instead of having to pass through the giant config ball. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
test the api is available when start is called. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
fixes #101 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
2 mins is still timeout after node restarts License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
- grab p2p addrs from origins if we can. - limit origins to 10, just so we dont accept unboundedly long origins lists License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
|
@olizilla mind rebasing this before review please? 🙏🏼 Most of this diff is already in #main and makes quite difficult to review changes |
|
Sorry! done! note, i'd encourage merging from main rather than rebase these days as:...
|
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
Non blocking feedback. But thing would be good to be addressed
| return input | ||
| .split(',') | ||
| .filter(isMultiaddr) | ||
| .filter(hasPublicIpAddress) |
There was a problem hiding this comment.
No more usage of this function. Looks like we can remove it
| import { findUsableMultiaddrs } from '../basic/helper/multiaddr.js' | ||
|
|
||
| const fixture = [ | ||
| '/ip4/127.0.0.1/tcp/4001/p2p/12D3KooWADjHf2kyANQodg9z5sSdX4bGEMbWg7ojwu6SCyDAMtzN', |
There was a problem hiding this comment.
Could we add a dns4 address just to make sure everything is working as expected for non hasBogonIpAddress?
2 participants
kubo provides it's own multiaddrs as origins on pin service requests when it has the blocks for a pin request locally. This PR aims to filter out unusable multiaddrs early, and make a best effort to convert them into something we can connect to.
License: MIT