[speculation-rules] Fire error events for invalid speculation rules#53821
[speculation-rules] Fire error events for invalid speculation rules#53821chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This CL introduces error handling for <script type=speculationrules>, mirroring the behavior of <script type=importmap>. Specifically, it adds error events for two cases: - Inline speculation rules with unparsable JSON. - External speculation rules, which are not yet supported. This is verified by new web platform tests. This follows the spec change at whatwg/html#11426. Change-Id: I9b0776b86059f6c8734d57c17f50ed26e89215da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6758353 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#1488632}
250d2b5 to
0d8d00f
Compare
This PR doesn't change anything infra-related, so I have no idea why the decision task for this PR and #53822 in particular are failing, and no other PRs are. I've already tried rebasing/retrying CI at different times, but the failure is consistent. @jcscottiii Should we just try merging anyway? |
|
I agree that these two PRs do not look infra related. I merged one just for now. We can watch the checks for this commit 8c89451. If all goes well, I will merge this one too. |
|
Hey @jonathan-j-lee, I think it is actually safe to merge. I created a rebased version here: #53879 And it works. |
|
Thanks @jcscottiii! My goal here was actually to try and isolate what about this PR was causing the decision task failure by mutating this PR's title/description until it matched your passing PR #53879. It looks like the CI for this PR was fixed by scrubbing the PR description. There might be a connection between |
Change-Id: I9b0776b86059f6c8734d57c17f50ed26e89215da