Regress display-mode's Baseline status#3744
Open
ddbeck wants to merge 1 commit intoweb-platform-dx:mainfrom
Open
Regress display-mode's Baseline status#3744ddbeck wants to merge 1 commit intoweb-platform-dx:mainfrom
display-mode's Baseline status#3744ddbeck wants to merge 1 commit intoweb-platform-dx:mainfrom
Conversation
3f8438f to
516a2f1
Compare
516a2f1 to
fa91f2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This PR assigns new
display-modemedia query value keys, regressingdisplay-mode's support.Previously, BCD's
display-modedata was incomplete with some data recorded in notes while other issues were not recorded at all. I fixed the data in BCD, which caused these new keys to appear:css.at-rules.media.display-mode.browsercss.at-rules.media.display-mode.fullscreencss.at-rules.media.display-mode.minimal-uicss.at-rules.media.display-mode.standalonecss.at-rules.media.display-mode.window-controls-overlayThis PR assigns the first five keys to
display-mode(on main: source, dist), while the last is assigned towindow-controls-overlay(on main: source, dist).Unfortunately, this work revealed that the media query values' behavior varies significantly between Firefox and Safari. For example, in Safari the fullscreen API does not affect the
display-modemedia query and in Firefox thefullscreenquery is true even when the browser UI is visible.See mdn/browser-compat-data#28868 for further details.