You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@eerii I'd love your help with this. Would you, by any chance, be willing to review the names and descriptions of the 2 yaml files in this PR.
This is for updating/creating 2 features on the web-features repository to cover MathML. One of these features already exists, and is meant to cover MathML Core. While the other feature is being added by this PR, and covers MathML full, and it comes with a message to discourage use in web content.
Do these descriptions/scopes make sense to you?
Looks good! The descriptions are very explanatory. I read the attached issues and I agree that "discouraged" (with the reason you put in the yaml) is more accurate than "deprecated". And grouping them by belonging to MathML Core or not makes sense too. Thank you for making this :)
@ddbeck could you please review? Also see @eerii's (yes, this Eri 😀) comment above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature definitionCreating or defining new features or groups of features.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2513 by creating a new discouraged feature which contains the remaining deprecated MathML BCD keys.