Conversation
github-actions
bot
added
the
team
There was a problem hiding this comment.
Pull request overview
Updates the rspack-sftrace agent skill documentation to include sftrace filter usage and a more explicit “run in example directory” workflow for generating/recording/analyzing traces.
Changes:
- Expand workflow to build a profiling binding and optionally generate an
sftrace.filterfile from the.nodesymbols. - Document full vs filtered recording outputs stored under a per-run trace directory in the target example.
- Add “Filtering Notes” caveats to clarify limitations of symbol-based filtering.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### 5) Analyze sf.log | ||
|
|
||
| Convert sftrace log to perfetto protobuf format. | ||
|
|
||
| ```sh | ||
| sftrace convert sf.log -o sf.pb.gz | ||
| cd examples/react | ||
| TRACE_DIR="sftrace-YYYYMMDD-HHMMSS" # replace with your run directory | ||
| sftrace convert "$TRACE_DIR/sf.filtered.log" -o "$TRACE_DIR/sf.filtered.pb.gz" |
There was a problem hiding this comment.
The section title says "Analyze sf.log", but the example converts sf.filtered.log into sf.filtered.pb.gz. This is confusing for users who recorded the full trace. Consider either renaming the header to refer to the filtered log, or show both conversions (full + filtered) with matching filenames.
| ### 5) Optional: Visualization using [viztracer](https://github.com/gaogaotiantian/viztracer) | ||
| ### 6) Optional: Visualization using [viztracer](https://github.com/gaogaotiantian/viztracer) | ||
|
|
||
| ```sh |
There was a problem hiding this comment.
The vizviewer example references $TRACE_DIR, but that variable isn't defined in this code block (and step 5 defines it as a placeholder value). Consider adding a one-liner in the snippet to set TRACE_DIR (or explicitly say "reuse TRACE_DIR from step 4") to make the copy/paste flow work.
| ```sh | |
| ```sh | |
| TRACE_DIR="sftrace-YYYYMMDD-HHMMSS" # replace with your run directory |
1 participant
Summary
add sftrace filter support in skill
Related links
Checklist