Adding gid to user_group and user_groups.#58
Open
brianhartsock wants to merge 1 commit intoweareinteractive:masterfrom
Open
Adding gid to user_group and user_groups.#58brianhartsock wants to merge 1 commit intoweareinteractive:masterfrom
brianhartsock wants to merge 1 commit intoweareinteractive:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted
user_groupandusers_groupparameters to objectives, supportingnameand optionalgidproperties. This is a breaking change. It should be possible to detect string or object and convert to avoid this being a breaking change, however I wanted to check the appetite on merging this before doing more work.