forked from wizeline/react-certification-2020
-
Notifications
You must be signed in to change notification settings - Fork 52
Uriel Contreras - Deliverable #1 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
UriConMur
wants to merge
18
commits into
wdonet:master
Choose a base branch
from
UriConMur:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
633839c
refactor: migrate to cra 4
UriConMur ea8fb10
fix: husky, commitlint and config files
UriConMur 534187b
fix: browserslist file name
UriConMur 690d84d
feat: add eslint security and compatibility
UriConMur 9551e61
feat: add layout structure with themes
UriConMur 5021c6c
feat: add initial folder structure with initial layout
UriConMur 97bb0a5
feat: add new styles and components
UriConMur 0853ec0
chore: remove not needed section at main readme
UriConMur 7b154d1
feat: change src/index to js
UriConMur 99be70b
chore: add live link to readme
UriConMur 02d6ca2
feat: add tests and coverage
UriConMur 727a2b4
docs: add test:coverage to readme
UriConMur 14ce2e8
Merge branch 'master' of github.com:UriConMur/react-certification-2021
UriConMur 55c4d4c
feat: add coverage report
UriConMur 4d169b6
fix: add badged for coverage instead of text file
UriConMur 4018798
test: add main styled component tests
UriConMur 5d37633
fix: lint staged
UriConMur 6277001
fix: order in lin staged
UriConMur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "extends": ["@commitlint/config-conventional"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| FAST_REFRESH=false | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| FAST_REFRESH=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "hooks": { | ||
| "commit-msg": "commitlint -E HUSKY_GIT_PARAMS", | ||
| "pre-commit": "lint-staged", | ||
| "pre-push": "npm run lint" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "*.{js,jsx,css,json}": [ | ||
| "npm run lint:fix", | ||
| "npm run test:coverage", | ||
| "pretty-quick --staged" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,75 @@ | ||
| # Wizeline Academy - 2021 React Bootcamp | ||
| # Web Application | ||
|
|
||
| Please refere to the following [GIST](https://gist.github.com/jparciga/83341911fbc8cd716be12af50c0e496a) for further instructions | ||
| This was created using create-react-app 4 | ||
| Try it live @ Netlify -> https://uri-react.netlify.app/ | ||
|
|
||
| | Statements | Branches | Functions | Lines | | ||
| | --------------------------- | ----------------------- | ------------------------- | ----------------- | | ||
| |  |  |  |  | | ||
|
Comment on lines
+6
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice touch! |
||
|
|
||
| ## Application Dependenciess | ||
|
|
||
| These are the system dependencies you need to have in order to run the application. | ||
|
|
||
| | Tool | Version | | ||
| | ----------------- | ------- | | ||
| | React-Scripts | 4.0.2 | | ||
| | React | >17.0.1 | | ||
| | Styled Components | | | ||
| | Jest | | | ||
|
|
||
| ### Frontend | ||
|
|
||
| | Tool | Description | | ||
| | ----------------- | --------------------------------------------------------- | | ||
| | React | Using React Library to render the Single Page Application | | ||
| | Styled Components | Using Styled Components to build CSS-in-JS | | ||
| | | | | ||
|
|
||
| --- | ||
|
|
||
| ### Testing | ||
|
|
||
| | Tool | Description | | ||
| | ---- | ---------------------------------------------------------------- | | ||
| | Jest | Using Jest Testing Framework to ensure correctness functionality | | ||
| | | | | ||
|
|
||
| ### Methodologies | ||
|
|
||
| | Methodology | Description | | ||
| | ----------- | --------------------------------------------------------- | | ||
| | SMACSS | Using SMACSS methodology for CSS construction | | ||
| | BEM | Using BEM structure for class names if needed. | | ||
| | i11y | Building an application with accessibility best practices | | ||
| | i18n | Building an application ready for internationalization | | ||
| | | | | ||
|
|
||
| ## Available Scripts | ||
|
|
||
| In the project directory, you can run: | ||
|
|
||
| ### `npm start` | ||
|
|
||
| Runs the app in the development mode.\ | ||
| Open [http://localhost:3000](http://localhost:3000) to view it in the browser. | ||
|
|
||
| The page will reload if you make edits.\ | ||
| You will also see any lint errors in the console. | ||
|
|
||
| ### `npm test` | ||
|
|
||
| Launches the test runner in the interactive watch mode.\ | ||
| See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. | ||
|
|
||
| Run: `npm run test:coverage` to check the coverage report. | ||
|
|
||
| ### `npm run build` | ||
|
|
||
| Builds the app for production to the `build` folder.\ | ||
| It correctly bundles React in production mode and optimizes the build for the best performance. | ||
|
|
||
| The build is minified and the filenames include the hashes.\ | ||
| Your app is ready to be deployed! | ||
|
|
||
| See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this file was intended to be tracked. I see the
.env.sample