Making sure withOffset works in tandem#267
Open
timbrandin wants to merge 4 commits intowcandillon:masterfrom
Open
Making sure withOffset works in tandem#267timbrandin wants to merge 4 commits intowcandillon:masterfrom
timbrandin wants to merge 4 commits intowcandillon:masterfrom
Conversation
When rendering an animated component that uses two withOffset values, they will affect each other and keep incrementing if we don't reset the state to undetermined, because in PanGestureHandler it does not reset by itself.
```
return (
<Animated.View
style={{
width: sub(value2, value1),
}}
/>
);
```
Owner
|
Can you tell me more about this, I'm not sure I understand. |
Author
|
Better I show instead! Before: After: |
wcandillon
reviewed
May 8, 2020
| ); | ||
| block([ | ||
| onChange(state, [ | ||
| cond(eq(state, State.END), [ |
Owner
There was a problem hiding this comment.
value shouldn't be written here. Should it be a separate function?
|
@timbrandin Hi, I am wondering this component open source ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendering an animated component that uses two withOffset values, they will affect each other and keep incrementing if we don't reset the state to undetermined, because in PanGestureHandler it does not reset by itself.
Edit: a better solution I came up with was to add onChange around the cond, so that it doesn't re-trigger due to another variable updating.