Skip to content

Update test to pass expected parameter #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosalieper merged 1 commit into from
Nov 27, 2025
Merged

Update test to pass expected parameter #1016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/Routes/Backend/WikiReadOnlyControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class WikiReadOnlyControllerTest extends TestCase {
public function testItReturns404WhenWikiNotFound() {
$response = $this->putJson($this->route, [
'domain' => 'nonexistent.wikibase.cloud',
'readOnly' => true,
'readOnly' => 1,
]);

$response->assertStatus(404)
Expand All @@ -31,7 +31,7 @@ public function testSetWikiToReadOnly() {

$response = $this->putJson($this->route, [
'domain' => 'somewiki.wikibase.cloud',
'readOnly' => true,
'readOnly' => 1,
]);

$response->assertStatus(200)
Expand All @@ -56,7 +56,7 @@ public function testDeleteSettingForReadOnlyFalse() {

$this->putJson($this->route, [
'domain' => $wiki->domain,
'readOnly' => false,
'readOnly' => 0,
Copy link
Contributor

@tarrow tarrow Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this worked before? Simply because it was false not "false"?

])
->assertStatus(200)
->assertJson(['message' => 'Read-only setting successfully removed for wiki.']);
Expand Down
Loading