Open
Conversation
Fix in output for "Hardware Version"
Fix to memory size calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found two errors in the code:
The second fix is including MIFARE Ultralight, DESFire Families and NTAGs as well. I know that the current library has problems to fetch this information, e.g. Ultralight Cards and NTAG 2xx do not support ISO 7816 APDU wrapping and return 7 byte only (the first block), but I hope that the library might be extended to support those cards as well as tags that are ISO compliant. I've done some modifications, but they are in an early state. I've read that some DESFire EV2 and EV3 cards may have small memory sizes, so I've included the full formula.
I would like that the scope of the library might cover the cards/tags in the future with a simple verification of the length of the input, e.g. "if len(data) < 8: return" in init and repr, but I haven't included such lines in the my first PR to this library.
I've done all tests as described and the code has passed these tests.