feat: add char and bool literal support with escape sequences #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement character literals, boolean literals, and improve numeric
literal parsing with proper hexadecimal support.
Changes:
- Add char literal tokenization in lexer:
- Parse single-quoted characters ('A', 'x', etc.)
- Support escape sequences (\n, \t, \r, \\, \', \")
- Validate proper char literal termination
- Add TokenType::CharLiteral(char) variant
- Add boolean literal keywords:
- Recognize "true" and "false" as language keywords
- Add TokenType::BoolLiteral(bool) variant
- Parse directly to boolean values in lexer
- Refactor numeric literal parsing:
- Fix hexadecimal literal handling (0x prefix)
- Separate hex, decimal, and float parsing logic
- Remove intermediate string manipulation
- Handle digit accumulation character-by-character
- Properly consume digits after decimal point
- Extend AST literal types:
- Add Literal::Bool(bool) for boolean values
- Add Literal::Char(char) for character values
- Add Literal::Byte(u8) for byte values (alias for char)
- Implement LLVM IR generation for new literals:
- Bool: Generate i1 const_int (0 or 1)
- Char: Generate i8 const_int with ASCII value
- Byte: Generate i8 const_int with byte value
- Add variable initialization support in codegen:
- Handle Bool, Char, Byte literals in store operations
- Convert literal values to appropriate LLVM types
- Support initialization with literal values
- Fix clang warning suppression:
- Add -Wno-override-module flag to silence module warnings
- Remove duplicate stdin pipe declaration
- Update test suite:
- test71.wave: Demonstrate all supported type literals
- Show i32, u32, f32, str, bool, byte, char, ptr, array usage
Example usage:
var flag: bool = true;
var letter: char = 'A';
var newline: char = '\n';
var hex: i32 = 0xFF;
This completes Wave's basic literal support with industry-standard
syntax for characters, booleans, and hexadecimal numbers.
Signed-off-by: LunaStev <luna@lunastev.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements foundational literal support for character and boolean types, alongside significant improvements to numeric literal parsing. These changes bring Wave's literal handling closer to industry standards, supporting common escape sequences and proper hexadecimal representation.
Key Changes
1. Lexer Enhancements
'a').\n,\t,\r,\\,\',\".trueandfalseas dedicated keywords rather than mere identifiers.0xprefix).2. AST & Type System
Literalenum in the AST to include:Literal::Bool(bool)Literal::Char(char)Literal::Byte(u8)3. LLVM Code Generation
i1constant (0 or 1).i8constant based on ASCII/byte values.storeoperations.4. Backend & Tooling
-Wno-override-moduleflag to suppress non-critical warnings during the compilation of generated IR.Example Usage
Verification Results
test71.wavewas added/updated to verify:i32,u32,f32.charandbytetype compatibility.