Add LLVM backend version reporting and improve help formatting #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add compile-time LLVM version detection and display in --version output,
plus improve help text readability with aligned columns.
Changes:
- Set LLVM version at build time via cargo:rustc-env:
- Export WAVE_LLVM_MAJOR=14 in all platform-specific linkers
- Linux (linux_original), macOS (link_macos), Windows (link_windows)
- Add backend() function to llvm_temporary/lib.rs:
- Retrieve WAVE_LLVM_MAJOR from compile-time environment
- Return formatted string "LLVM {version}" or None
- Display backend version in --version output:
- Call llvm_temporary::backend() from version_wave()
- Print "backend: LLVM 14" with gray color formatting
- Fallback to "backend: unknown backend" if unavailable
- Improve help text formatting in print_help():
- Use consistent column width alignment ({:<18}, {:<22})
- Add descriptive text for each command and option
- Group related options (Commands, Optimization, Debug)
- Expand optimization flag descriptions (-O0..-O3, -Oz, -Ofast)
- Clarify debug option purposes (tokens, AST, IR, MC, hex)
- Keep practical usage examples at bottom
Output example:
wavec 0.1.5-pre-beta (Linux 6.x.x)
backend: LLVM 14
This provides transparency about the compiler toolchain configuration
and improves CLI user experience with readable help formatting.
Signed-off-by: LunaStev <youngjae681@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds compile-time LLVM version detection and display in
--versionoutput, while improving help text readability with aligned column formatting.Changes
Backend Version Reporting
WAVE_LLVM_MAJOR=14viacargo:rustc-envin platform-specific linkers:backend()function inllvm_temporary/lib.rsWAVE_LLVM_MAJORfrom compile-time environment"LLVM {version}"orNoneif unavailable--versionoutputllvm_temporary::backend()fromversion_wave()"backend: unknown backend"if unavailableHelp Text Improvements
print_help(){:<18},{:<22})-O0through-O3,-Oz,-Ofast)Example Output