Skip to content

Conversation

@kang-amy
Copy link
Contributor

@kang-amy kang-amy commented Feb 11, 2023

CLICKUP TICKET LINK

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

A pre-commit hook to run prettier before commits to auto format code was added.
A .pre-commit-config.yaml file was added

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test

When committing code, the pre-commit hooks should run within your terminal on all files changed and pass. In order to test my changes, the code I committed in the .yaml file that I added was successfully linted on commit. Note: when adding the pre-commit hook, I didn't run against all files in the codebase.

  • Checked "/example" endpoint on postman
  • Change passes all integration tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation/READ-ME/UMLS (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@kang-amy kang-amy self-assigned this Feb 11, 2023
@jennchenn
Copy link

@kang-amy kang-amy requested a review from tahazaryab April 7, 2023 02:14
Copy link

@tahazaryab tahazaryab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and works great!

we should probably add instructions to the README on how to install pre-commit, and to run pre-commit install when first setting up the project since that's required for this to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants