Skip to content

To get accessToken from request headers instead of sending it in the … #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
G-Wang12 wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −10
Open

To get accessToken from request headers instead of sending it in the … #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/backend/api/email/update-email-sent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,23 @@ import { sendEmail } from './helper';
export default async (req, res) => {
const appID = req.body.id;

// send the actual email, then check if email sent correctly
if (req.body.accessToken) {
await sendEmail(req.body, req.body.accessToken); // TODO: check if accessToken sent securely.
const cookieHeader = req.headers?.cookie;
if (cookieHeader) {
const list = {};
cookieHeader.split(';').forEach(cookie => {
let [name, ...rest] = cookie.split('=');
name = name?.trim();
if (!name) return;
const value = rest.join('=').trim();
if (!value) return;
list[name] = decodeURIComponent(value);
});
console.log('cookieHeader::', list)

// send the actual email, then check if email sent correctly
if (list.accessToken) {
await sendEmail(req.body, list.accessToken); // TODO: check if accessToken sent securely.
}
}

try {
Expand Down
8 changes: 1 addition & 7 deletions src/frontend/hooks/email.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,14 @@ import { useCallback } from 'react';
import { useDispatch } from 'react-redux';
import api from 'frontend/api';
import * as applicationActions from 'frontend/state/applications/actions';
import CookiesHelper from './cookies.js';

const useEmail = () => {
const dispatch = useDispatch();

const updateEmailStatus = useCallback(
async (emailData) => {
try {
const { getCookie, CookieTags } = CookiesHelper;
const accessToken = getCookie(CookieTags.accessToken);
const res = await api.email.updateApplicationEmailSent({
...emailData,
accessToken,
});
const res = await api.email.updateApplicationEmailSent(emailData);

if (res.status !== 200) {
throw new Error(
Expand Down