Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of small bugfixes and speedups for the BVH utilisation for TransferDictionariesBySelectors
Vertex.IsInternal bugs were causing fails for L-shaped faces, where centroid is not on the face.
Hidden typo in a try block permanently failed and caused a fallback.
FInding face internal vertex for irregular faces does not benefit from using BVH to run a single query.
Creating a BVH for the primitives in Topology.TransferDictionariesBySelectors to use for all the selector queries is where it has most benefit. Otherwise Vertex.IsInternal on a cluster was matching each primitive on its own.
The performance effects of triangulated face centres vs internal edge centres may be arguable.
Going for triangle centres feels more straightforward, but tested difference is actually negligible.
AABB for a point clash can be created directly instead of going through a additional data structure.
Hope it makes sense.