feat: Implement github SDK with access token support#138
Open
asvinours wants to merge 2 commits intowarrensbox:masterfrom
Open
feat: Implement github SDK with access token support#138asvinours wants to merge 2 commits intowarrensbox:masterfrom
asvinours wants to merge 2 commits intowarrensbox:masterfrom
Conversation
|
I prefer the current mechanism of using https://warrensbox.github.io/terragunt-versions-list/index.json which is generated from https://github.com/warrensbox/terragunt-versions-list The Github API has usage restrictions when not authenticated and my organization doesn't use github so managing github credentials for this would be difficult. If this is popular, I would suggest making it an option to use this instead of the Proxy but not replace it outright. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #132 and #133
changes summary:
https://warrensbox.github.io/terragunt-versions-list/index.jsonmake test output