WA-24452: Update Testify #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed minor mistake in readme example
Remove unnecessary use of reflect in the implementation of mock.FunctionalOptions().
The comments for the require package were just copied over from the assert package when generating the functions. This could lead to confusion because 1. The code-examples were showing examples using the assert package instead of the require package 2. The function-documentation was not mentioning that the functions were calling `t.FailNow()` which is some critical information when using this package.
Co-authored-by: Olivier Mengué <dolmen@cpan.org>
assert: IsIncreasing et al can return false w/out failing
…h_type add type to error message of assert.Same
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
…ultidoc assert.YAMLEq: Document mutlidoc behavior
Previously passing a mock.Mock by value rather than by reference worked (in cases without mutex locking issues) and logged a warning. This was broken by stretchr#1212 which introduced a breaking change in an attempt to fix go vet. There is no clean way to fix the breaking change as we now have (and want) go vet in our CI. This PR does not revert the breaking change but changes the panic to a test failure with a useful message.
…ationsForObjects-panic mock.AssertExpectationsForObjects fix panic with wrong testObject type.
Godoc does not have inline code blocks. Look to the standaed library for conventions for inline references to code.
Copy code from dependency github.com/ernesto-jimenez/gogen/imports (which hasn't evolved since 2018) as package _codegen/internal/imports. This is imported from https://github.com/ernesto-jimenez/gogen at commit d7d4131e6607813977e78297a6060f360f056a97. See https://github.com/ernesto-jimenez/gogen/tree/d7d4131e6607813977e78297a6060f360f056a97/imports The license block is added to match the LICENSE file from the source repository.
Use our imported copy of package github.com/ernesto-jimenez/gogen/imports to remove one external dependency.
_codegen: copy dependency github.com/ernesto-jimenez/gogen/imports
These were previously inline code blocks (which go does not support) containing reference to a single symbol. Link to the symbol instead.
assert: truncate very long objects in test failure messages
doc: remove ineffective inline code blocks
nikitaratnikov
changed the title
nikitaratnikov
requested review from
Djenchik,
ISkobelevHostwerk and
jevgeni17
ISkobelevHostwerk
approved these changes
Sep 22, 2025
jevgeni17
approved these changes
Sep 23, 2025
tanel
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated our forked testify to last version