Skip to content

⚡ Bolt: optimize file reading and fix sed bug #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: optimize file reading and fix sed bug #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-01-01 - Broken sed pipe causing data loss
**Learning:** `sed 's// /g'` (empty regex) causes exit code 1 and silent data loss in pipes on some Bash versions; `tr` should be used for simple character filtering.
**Action:** Always check exit codes of commands in pipes or use safer alternatives like `tr`.
4 changes: 3 additions & 1 deletion codepack.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,9 @@ extract_files_content() {
# Read file content and clean invalid characters
local content=""
if [[ -r "$file" && -s "$file" ]]; then
content=$(cat "$file" 2>/dev/null | sed 's// /g' 2>/dev/null | tr -cd '\11\12\15\40-\176' 2>/dev/null || echo "")
# Optimization: Use direct redirection instead of cat|sed to reduce process forks
# and fix bug with invalid sed command
content=$(tr -cd '\11\12\15\40-\176' < "$file" 2>/dev/null || echo "")
fi

debug_log "Content length: ${#content}" >&2
Expand Down