Conversation
SSE Reliability Fixes: - Fix PHP session locking blocking SSE connections - Add session_write_close() before rendering import page - Add SSE retry mechanism with exponential backoff (100ms-1600ms) - Fix output buffering order in SseService (ini_set before ob_end_clean) - Add ~8KB padding to force Apache/mod_fcgid buffer flush - Change return to exit after SSE error to prevent Response corruption Documentation: - Add "How It Works" section explaining staggered import behavior - Enhance Troubleshooting with Laragon-specific config paths - Add quick diagnostic command (php -S localhost:8000) - Document server configurations for SSE (Apache, nginx, Laragon) Git Cleanup: - Fix .gitignore to use **/CLAUDE.md pattern for all subdirectories - Remove CLAUDE.md files from git tracking
Add support for .bz2 and .sql.bz2 compressed SQL dump imports alongside existing .gz support, with full resume functionality via seek workaround. Key features: - BZ2 file detection with case-insensitive extension matching - bzopen/bzread/bzclose integration in FileHandler - ADR-001: Seek workaround using re-read strategy (O(n) resume time) - Conditional support based on PHP ext-bz2 availability - Purple "BZ2" badge in file listing - Frontend validation with custom error messages - Comprehensive test suite (24 tests across 4 files) Files modified: - src/Models/FileHandler.php - Core BZ2 support - src/Config/Config.php - Extension config + isBz2Supported() - templates/home.php - UI badge + data-bz2-supported - assets/js/fileupload.js - Conditional validation Test files created: - tests/FileHandlerBz2Test.php - tests/ConfigBz2Test.php - tests/FrontendBz2Test.php - tests/Bz2IntegrationTest.php - tests/fixtures/test_bz2_import.sql.bz2
Owner
Author
|
Wrong way main → develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolution
After investigation, the XML code was actually dead legacy code from 2013 — the frontend already uses JSON via SSE.
What was removed (~140 lines):
createXmlResponse(),xmlElement(),formatNullable(),createProgressBar()from AjaxServiceajaxImport()from BigDumpControllerajax_importroute from ApplicationWhat was kept (already JSON):
sseImport()— active SSE streaming endpointpreview(),history(),filesList()— already return JSONJSON.parse()/response.json()Verification: