Remove milestone2 of choko wallet #1772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Noc2
approved these changes
May 30, 2023
Contributor
Noc2
left a comment
Noc2
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good to me, and I will mark it as ready for review.
Noc2
added
ready for review
keeganquigley
approved these changes
May 30, 2023
Collaborator
keeganquigley
left a comment
keeganquigley
left a comment
There was a problem hiding this comment.
Thanks @RoyTimes LGTM.
takahser
approved these changes
May 31, 2023
randombishop
approved these changes
May 31, 2023
Noc2
added a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref to #1022
The TL;DR : we are removing Milestone2 because it no long fits well with the current wallet ecosystem anymore.
Wallets greatly evolved since Aug, 2022 when we initially submitted this applications. The simple cross-chain wallets will no longer help us remain competitive in the space anymore. Choko has since focused on eliminating private keys management with MPC-ECDSA/EdDSA ever since. Therefore, we are proposing to remove Milestone2 from this application and remain very enthusiastic for submitting further grant applications that fits better into what we are currently working on.