Open
Conversation
9 tasks
Contributor
Author
|
The build error appears to be preexisting. |
Member
|
The build error should be fixed with #777. |
This upstreams the monkeypatches from https://wicg.github.io/nav-speculation/speculation-rules.html#content-security-policy. At a high level, the additions are: - A new directive, `inline-speculation-rules`, which can be used if developers want to block inline JavaScript `<script>`s but allow inline `<script type=speculationrules>`s. This is done by introducing a new script type, `script speculationrules`, to sit alongside the existing `script` and `script attribute` types; HTML passes this new value in. - Handling of the new `"speculationrules"` request destination, which is used by the `Speculation-Rules` HTTP header. It cannot be blocked by CSP.
16bb13b to
8c2dcb5
Compare
Contributor
Author
|
Rebased! |
Contributor
Author
|
This is ready to merge! |
mikewest
approved these changes
Sep 24, 2025
Member
mikewest
left a comment
There was a problem hiding this comment.
This LGTM, and as it's landed in HTML it should meet the requirements we're starting to pull together for additions to CSP.
I'll wait a bit for @antosart to have any feedback, but I'm comfortable merging this at this point.
Thanks!
5 tasks
Member
|
This looks good to me, too, but see whatwg/fetch#1841 (comment). Would it make sense to provide more context and link to some reasoning on the decision of gating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upstreams the monkeypatches from https://wicg.github.io/nav-speculation/speculation-rules.html#content-security-policy. At a high level, the additions are:
A new directive,
inline-speculation-rules, which can be used if developers want to block inline JavaScript<script>s but allow inline<script type=speculationrules>s. This is done by introducing a new script type,script speculationrules, to sit alongside the existingscriptandscript attributetypes; HTML passes this new value in.Handling of the new
"speculationrules"request destination, which is used by theSpeculation-RulesHTTP header. It cannot be blocked by CSP.This should be merged a bit after whatwg/html#11426. Otherwise it will reference the WICG draft.
Preview | Diff