feat: Switch to direct download of vnu.jar (rather than npm package)#216
Open
sideshowbarker wants to merge 1 commit intomainfrom
Open
feat: Switch to direct download of vnu.jar (rather than npm package)#216sideshowbarker wants to merge 1 commit intomainfrom
sideshowbarker wants to merge 1 commit intomainfrom
Conversation
sideshowbarker
force-pushed
the
sideshowbarker/download-vnu-jar
branch
from
5137905 to
e16cb54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #215. I haven’t figured out how to actually test this…
But anyway: Putting this patch together has made me realize that instead just requiring the npm vnu-jar package is vastly simpler than this. I mean, to instead switch to downloading the vnu.jar — as this change does — basically requires re-creating all the same stuff that just using the npm package does transparently for us, behind the scenes.
So… perhaps we don’t actually want to merge this. Instead, maybe we can just keep it around here for use as a “backup plan” for if/when I ever end up breaking the npm package again.