Skip to content

Conversation

@martinthomson
Copy link
Member

@apasel422
Copy link
Collaborator

Can we also set https://docs.npmjs.com/cli/v11/configuring-npm/package-json#license in impl/package.json for completeness?

@martinthomson
Copy link
Member Author

Given that this is "private": true, I don't see there being much point.

@apasel422
Copy link
Collaborator

Given that this is "private": true, I don't see there being much point.

IIUC, private just means that the package won't be published, but it seems orthogonal to the license, since someone can download the repository without using the package through NPM.

I'm mainly interested in this for the case in which a tool automatically imports the end-to-end tests for use with a non-simulator implementation.

It also doesn't seem out of the question that we could publish this package at some point.

@martinthomson
Copy link
Member Author

In the case where someone downloads the repository or pulls specific resources from it, wouldn't they be pulling from here, where there is a license? The reason I mentioned the "private" attribute in package.json is that this precludes distribution of the impl/ directory via NPM, which is the only way in which a license might be needed there.

If the package ever is published, that's a different story. We'd need to populate a bunch of fields in addition to the license.

@martinthomson martinthomson merged commit bf7d64a into main Jan 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should this repo have explicit license information?

3 participants