Fixed issue with duplicate checker by using array_count_values() to determine if a node has the same name#13
Open
Sammyjo20 wants to merge 5 commits intovyuldashev:masterfrom
Sammyjo20:master
Open
Fixed issue with duplicate checker by using array_count_values() to determine if a node has the same name#13Sammyjo20 wants to merge 5 commits intovyuldashev:masterfrom Sammyjo20:master
array_count_values() to determine if a node has the same name#13Sammyjo20 wants to merge 5 commits intovyuldashev:masterfrom
Sammyjo20:master
Conversation
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Hi @vyuldashev 👋
Thank you for this great little package, it's helped me massively with a project we've had to built quickly. I ran into a small issue however which was with some of the XML I was processing. One section of the XML had the following child nodes:
I found an issue where the
sameNamevariable wouldn't betruebecause of the last<ProductCount>child node causing theisHomogenousmethod to returnfalse.I have solved this issue by using
array_count_valueswhich will count up all of the occurrences of each of the duplicated nodes, and when it checks to see if a node already exists, we check the$sameNamesOccurrencesarray for duplicates.All tests are passing fine and it seems to work for my solution too. I hope you get a chance to review and potentially accept this PR! 🤓
Have a great day. ☀️