-
Notifications
You must be signed in to change notification settings - Fork 0
Form validation #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vwagh-dev
wants to merge
6
commits into
main
Choose a base branch
from
level2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ec888b9
Added global configuration page with one text box & textarea each i.e…
vwagh-dev c45d2f9
Added form validation i.e. level2
vwagh-dev 4d7b540
Added getter/setter for the form fields.
vwagh-dev 1dcf441
Added form validation i.e. level2
vwagh-dev ac3cf80
Rebase with #level1
vwagh-dev fc2ffce
Empty-Commit
vwagh-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
39 changes: 39 additions & 0 deletions
39
...a/io/jenkins/plugins/sample/global_configuration/OnboardingPluginGlobalConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package io.jenkins.plugins.sample.global_configuration; | ||
|
|
||
| import hudson.Extension; | ||
| import hudson.util.FormValidation; | ||
| import jenkins.model.GlobalConfiguration; | ||
| import org.jenkinsci.Symbol; | ||
| import org.kohsuke.stapler.QueryParameter; | ||
|
|
||
|
|
||
| @Extension | ||
| @Symbol("OnboardingPlugin") | ||
| public class OnboardingPluginGlobalConfiguration extends GlobalConfiguration { | ||
| private String name; | ||
| private String description; | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public void setName(String name) { | ||
| this.name = name; | ||
| } | ||
|
|
||
| public String getDescription() { | ||
| return description; | ||
| } | ||
|
|
||
| public void setDescription(String description) { | ||
| this.description = description; | ||
| } | ||
|
|
||
| public FormValidation doCheckName(@QueryParameter String name) { | ||
Check warningCode scanning / Jenkins Security Scan Stapler: Missing permission check
Potential missing permission check in OnboardingPluginGlobalConfiguration#doCheckName
Check warningCode scanning / Jenkins Security Scan Stapler: Missing POST/RequirePOST annotation
Potential CSRF vulnerability: If OnboardingPluginGlobalConfiguration#doCheckName connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
|
||
| String regex = "^[a-zA-Z ]+$"; | ||
| if (!name.matches(regex)) { | ||
| return FormValidation.warning("Name must contains characters & spaces"); | ||
| } | ||
| return FormValidation.ok(); | ||
| } | ||
| } | ||
11 changes: 11 additions & 0 deletions
11
...kins/plugins/sample/global_configuration/OnboardingPluginGlobalConfiguration/config.jelly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <?jelly escape-by-default='true'?> | ||
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form"> | ||
| <f:section title="Onboarding Plugin"> | ||
| <f:entry title="${%Name}" field="name"> | ||
| <f:textbox checkMethod="post" /> | ||
vwagh-dev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </f:entry> | ||
| <f:entry title="${%Description}" field="description"> | ||
| <f:textarea checkMethod="post" /> | ||
| </f:entry> | ||
| </f:section> | ||
| </j:jelly> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.