Fix ColorConverter RGB input, layout toggle, and styling issues#35
Merged
Fix ColorConverter RGB input, layout toggle, and styling issues#35
Conversation
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several issues in the ColorConverter tool:
Changes Made
Fixed RGB NumberInput +/- button behavior
onChangeto Carbon's API signature(e, { value }) => ...Added alternating row backgrounds for code snippets
--cds-layerand--cds-layer-hoverFixed layout toggle functionality
Reorganized layout with always-visible history
Fixed prop type warnings
labelTextandhideLabelto TextInputmin/maxfrom strings to numbersConfigured Vite for IBM Plex fonts
~prefix from font imports@ibm/plexresolutionTesting
Related Issues
Fixes ColorConverter layout and input issues.