feat: add action icon to vscode-option#563
feat: add action icon to vscode-option#563alexander-heimbuch wants to merge 1 commit intovscode-elements:mainfrom
Conversation
|
@bendera I would appreciate some feedback here if you've got the time :) |
|
To be honest, I think this feature a bit odd. Even in MUI, which is very complex and full of features, there isn’t such this feature. However, it would be a great addition if we could put an icon before the text. I tried to implement it, but ran into performance issues. With long lists, like a list of countries, the hover state can feel noticeably laggy. This would probably happen with your feature too if the list is long. The main reason is that the hover state has to be handled with CSS classes, since the option needs to stay selected even when the cursor moves away. |
|
Thanks for the feedback, I already thought that this might be a stretch 👍 I would close this draft PR but feel free to use this as a feature container. |
This PR introduces an action icon to
vscode-optionthat allows interactions within the list, for example if you want to delete items from the list.Before changing the tests I wanted to get an opinion on this feature, so consider this as a proposal PR.