fix(textfield): do not bind .value for file inputs#543
Closed
dankeboy36 wants to merge 1 commit intovscode-elements:mainfrom
Closed
fix(textfield): do not bind .value for file inputs#543dankeboy36 wants to merge 1 commit intovscode-elements:mainfrom
dankeboy36 wants to merge 1 commit intovscode-elements:mainfrom
Conversation
The native file input cannot accept non-empty values programmatically. Skip mirroring and binding .value for type="file". Only propagating FileList to form internals. This prevents InvalidStateError and keeps file selections intact across renders. Closes vscode-elements#542 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
Member
|
👀 |
Contributor
Author
|
Not a bug. See #542 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native file input cannot accept non-empty values programmatically.
Skip mirroring and binding .value for type="file".
Only propagating FileList to form internals.
This prevents InvalidStateError and keeps file selections intact across
renders.
Closes #542