Skip to content

Conversation

@rajdama
Copy link

@rajdama rajdama commented Oct 12, 2021

Accordian section added

@netlify
Copy link

netlify bot commented Oct 12, 2021

✔️ Deploy Preview for reactbarebones ready!

🔨 Explore the source changes: a0dac7c

🔍 Inspect the deploy log: https://app.netlify.com/sites/reactbarebones/deploys/6165b5cd6e272200076927ef

😎 Browse the preview: https://deploy-preview-21--reactbarebones.netlify.app/

@vsanse
Copy link
Owner

vsanse commented Oct 13, 2021

Hi @rajdama ,

Thanks for the PR. I think we can expose some props where users can decide if all the tabs are to be opened together or just one at a time.

@vsanse vsanse self-requested a review October 13, 2021 06:15
@vsanse vsanse added enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Oct 13, 2021
@rajdama
Copy link
Author

rajdama commented Oct 13, 2021

@vsanse Can you explain little bit more I didn't got what you said

@rajdama
Copy link
Author

rajdama commented Oct 13, 2021

Screenshot 2021-10-13 120424
Should their be a button like this?

@vsanse
Copy link
Owner

vsanse commented Oct 13, 2021

Please check this: https://ant.design/components/collapse/

here if you see the collapse component it accepts a prop 'accordion' which defines if all the tabs can be opened together or one at a time.
for e.g:
if 'accordion:false`:
then you can open tabs without closing the previous one
else
when you open a tab previously opened tabs would be closed automatically.

@rajdama
Copy link
Author

rajdama commented Oct 13, 2021

@vsanse Got it.

@vsanse vsanse removed their request for review October 13, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants