fix: Deno 2 compatibility and ignore patterns support#36
Open
nLight wants to merge 2 commits intovrtmrz:mainfrom
Open
fix: Deno 2 compatibility and ignore patterns support#36nLight wants to merge 2 commits intovrtmrz:mainfrom
nLight wants to merge 2 commits intovrtmrz:mainfrom
Conversation
- Fix startup order: CouchDB peers init before storage peers - Add ignore patterns support for PeerStorage (glob-based filtering) - Add node-fetch-native dependency for fetch compatibility - Make Hub.start() async to properly await peer initialization Note: pouchdb-fetch requires manual patching after deno install to use native fetch instead of node-fetch for Deno compatibility. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Bug found: offline scan hangs when vault contains When Fix: Pass const ignorePatterns = this.config.ignore ?? [];
const skipRegexps = ignorePatterns.map(p => {
const escaped = lP.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
const pattern = p.replace(/\*\*/g, ".*").replace(/\*/g, "[^/]*");
return new RegExp(`${escaped}/${pattern}`);
});
for await (const entry of walk(lP, { skip: skipRegexps })) {Config example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for running on Deno 2:
Note: pouchdb-fetch requires manual patching after deno install to use native fetch instead of node-fetch for Deno compatibility.