feature: improve normalization logic for files to help synchronization logic#31
Open
sytone wants to merge 1 commit intovrtmrz:mainfrom
Open
feature: improve normalization logic for files to help synchronization logic#31sytone wants to merge 1 commit intovrtmrz:mainfrom
sytone wants to merge 1 commit intovrtmrz:mainfrom
Conversation
…n logic - Implemented normalization of file paths in Peer classes to prevent additional loops. - Introduced useNormalizedCachePaths configuration option across peers to ensure consistent cache lookups. - Enhanced README with detailed configuration options and explanations for new features. - Updated Deno imports for compatibility and improved path handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #29
On Windows, the synchronization was causing additional loops due to inconsistent path separators in cache keys causing updates to be pushed to peers that should have been skipped.
Root Cause
On Windows:
\)toPosixPath()have forward slashes (/)normalizeCacheKey()method wasn't normalizing separators\) or forward slashes (/) so that is also normalized.This ensures that:
"./vault/file.md"becomes"file.md""vault\file.md"becomes"file.md"(Windows)"vault/file.md"becomes"file.md"