Fix random object being added to playmode #105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meenphie
suggested changes
Oct 12, 2023
meenphie
left a comment
meenphie
left a comment
There was a problem hiding this comment.
There is no need to instantiate a dummy object and destroy it later. We can just make a local variable and directly set its parent to the _mainSceneCamera
Packages/com.vrchat.ClientSim/Runtime/CameraStacking/ClientSimStackedVRCameraSystem.cs
Outdated
Show resolved
Hide resolved
Packages/com.vrchat.ClientSim/Runtime/CameraStacking/ClientSimStackedVRCameraSystem.cs
Outdated
Show resolved
Hide resolved
Author
|
Fair enough, didn't want to be responsible for breaking anything in case the object being in scene mattered :) |
Co-authored-by: Fairplex <31825109+Fairpl3x@users.noreply.github.com>
Collaborator
|
It looks like this was fixed in SDK 3.5.1, though the release notes did not mention it. Thanks for your contribution! That's why there's a conflict in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
Pretty simple fix, Assign the dummy gameobject created to a variable so we can destroy it once we are done with it