perf(scan): skip summary fallback for bubble ballot errors #7976
+179
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Improves ballot interpretation performance by avoiding the slow summary-ballot (BMD) fallback when the initial bubble-ballot (HMPB) interpretation returns certain definitive bubble-ballot errors (per #7769).
Changes:
- Added
shouldSkipSummaryBallotInterpretationto classify “definitive” bubble-ballot errors where BMD fallback is unnecessary. - Updated
interpretSheetto return early (skipping BMD interpretation) when those definitive errors occur. - Added unit tests covering the skip-decision logic for several page types and unreadable reasons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/ballot-interpreter/src/interpret.ts | Adds skip-decision helper + early return in interpretSheet to avoid expensive fallback work. |
| libs/ballot-interpreter/src/should_skip_summary_ballot_interpretation.test.ts | New tests validating which bubble-ballot error outcomes should bypass summary fallback. |
libs/ballot-interpreter/src/should_skip_summary_ballot_interpretation.test.ts
Show resolved
Hide resolved
eventualbuddha
force-pushed
the
vxsuite-7769-ballot-interpreter-fallback
branch
2 times, most recently
from
0a4b35a to
b876165
Compare
Fixes #7769 When bubble ballot interpretation produces errors that definitively identify the ballot as a bubble ballot (wrong election hash, wrong precinct, wrong test mode, vertical streaks, invalid scale), skip the slow summary ballot fallback interpretation since it cannot produce a better result.
eventualbuddha
force-pushed
the
vxsuite-7769-ballot-interpreter-fallback
branch
from
b876165 to
7c0f37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #7769
When bubble ballot interpretation produces errors that definitively identify the ballot as a bubble ballot (wrong election hash, wrong precinct, wrong test mode, vertical streaks, invalid scale), skip the slow summary ballot fallback interpretation since it cannot produce a better result.
Demo Video or Screenshot
n/a
Testing Plan
Automated tests.