Skip to content
This repository was archived by the owner on Nov 3, 2020. It is now read-only.

fix: Prevent error about updating unmounted component.#92

Open
beausmith wants to merge 1 commit intomainfrom
prevent-update-on-unmounted-componenet
Open

fix: Prevent error about updating unmounted component.#92
beausmith wants to merge 1 commit intomainfrom
prevent-update-on-unmounted-componenet

Conversation

@beausmith
Copy link
Contributor

This has been a pain in my side since we started fetching the election def async!

The app will now stay on the page you're viewing when you make a change to the code and browser refreshes.

@beausmith
Copy link
Contributor Author

FML: Tests!

@beausmith
Copy link
Contributor Author

There is actually something broken with this commit.

@eventualbuddha
Copy link
Contributor

Keep or close?

@beausmith
Copy link
Contributor Author

Thx. Keep. Thus is still an issue. There is an issue with this fix.

@beausmith beausmith removed the request for review from eventualbuddha September 10, 2020 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants