Allows load testing for faxes #177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/votebymail/build/kbekmn3bg |
ludanin
force-pushed
the
feature/fax_load_testing
branch
from
262ed98 to
d4477d9
Compare
ludanin
force-pushed
the
feature/fax_load_testing
branch
from
d4477d9 to
fb35e80
Compare
tianhuil
requested changes
Sep 18, 2020
| @@ -1,3 +1,6 @@ | |||
| // To test this script for faxes run it using --faxes on the CLI, or by | |||
Contributor
There was a problem hiding this comment.
We don't want to send actual emails or faxes during the test. Is there a way to prevent this or to mock what gets sent?
tianhuil
requested changes
Sep 22, 2020
| const letter = new Letter(info, method, id, resendReasonAndOriginalDate) | ||
| const pdfBuffer = await toPdfBuffer(letter.render('html'), await letter.form) | ||
| const isResend = resendReasonAndOriginalDate !== undefined | ||
| // When performing signups for DIVERT_EMAIL we don't send emails or faxes |
Contributor
There was a problem hiding this comment.
This is wrong -- we use DIVERT_FAX_NUMBER and DIVERT_EMAIL separately. Let's stick to using that logic.
I don't think we should be editing signup.ts very much for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.