Fix broken menu button on non-touchscreen devices #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed website menu only opening on touch.
This was depended on by one single function. Upon refactoring that function, modernizr is now redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menu button was only working when tapped on touchscreen devices (i.e. it couldn't be clicked with a mouse.) I have fixed this issue and removed Modernizr.
Modernizr is useless for this website because the only thing for which it was being used was to detect touchscreen devices and make the menu button tappable. However, this is pretty redundant because the menu button will work on touchscreen devices anyway.
I have a demo of the fixed website up at http://kbrgl.github.io/devicons