Skip to content

Conversation

@jianjunzhong
Copy link
Contributor

…ad of by parameter passing

What does this PR do?

Use get_device_name() for automatic device detection in RayWorkerGroup instead of by parameter passing

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

…ad of by parameter passing

Signed-off-by: jianjunzhong <jianjunzhong@foxmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to improve automatic device detection in RayWorkerGroup by using get_device_name(). While this is a good improvement for the default behavior, the current implementation removes the ability to manually override the device via the device_name parameter, which is a breaking change and a loss of flexibility. My review includes a suggestion to retain this capability while still using automatic detection as the default.

# this WorkerGroup.
self.sub_cls_name = ""
self.device_name = kwargs.get("device_name", "cuda")
self.device_name = get_device_name()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The change from kwargs.get("device_name", "cuda") to get_device_name() improves the default device detection. However, it removes the ability for users to override the device by passing the device_name parameter to the RayWorkerGroup constructor. This is a potentially breaking change and a loss of flexibility. For instance, a user might want to run a CPU-only job on a machine with GPUs for testing purposes.

Several tests are also passing device_name as a keyword argument (e.g., in tests/single_controller/test_worker_group_basics.py), which will be ignored with this change.

To maintain flexibility while improving the default, I suggest using get_device_name() as the default value, but still allowing it to be overridden.

Suggested change
self.device_name = get_device_name()
self.device_name = kwargs.get("device_name", get_device_name())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant