Skip to content

Conversation

@hchings
Copy link
Collaborator

@hchings hchings commented Jan 9, 2026

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for TensorRT-LLM as a rollout engine. The changes are extensive, touching Dockerfiles, documentation, configuration, and core Python code for workers and trainers. The implementation adds a new trtllm rollout worker, server, and replica, integrating with the existing Ray-based infrastructure. The use of IPC for weight updates and careful management of placement groups for co-location of training and inference workers are notable. Overall, the changes seem well-designed to integrate TRTLLM, but there are a couple of points in the Dockerfile that could be improved for better reliability and maintainability.

RUN git clone -b v2.3.1 https://github.com/NVIDIA/gdrcopy.git && \
git clone https://github.com/deepseek-ai/DeepEP.git && cd DeepEP && git checkout a84a248 && \
cd /home/dpsk_a2a && \
wget https://developer.nvidia.com/downloads/assets/secure/nvshmem/nvshmem_src_3.2.5-1.txz && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The wget command on line 17 downloads nvshmem from a URL that contains /secure/. This often indicates that the resource is behind a login or requires some form of authentication, which can cause the Docker build to fail in automated CI environments. It's better to either host this dependency in a more accessible location or to use a base image that already includes it if possible. If this is a public but temporary URL, it's still a risk for long-term build reproducibility.

Comment on lines +64 to +65
RUN pip install git+https://github.com/volcengine/verl.git@v0.6.0
RUN pip uninstall -y verl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Installing verl from git and then immediately uninstalling it is a confusing pattern for managing dependencies. While this might be intended to cache the dependencies in a Docker layer, it makes the Dockerfile harder to understand and maintain. A more explicit approach would be better. For example, you could clone the repository, generate a requirements.txt from setup.py, and then install dependencies from that file. This would make the intent clear and separate dependency installation from the package installation.

@hchings hchings force-pushed the hchings/fix-ppo-flow branch from 578968c to 9db950d Compare January 10, 2026 06:51
joyang-nv and others added 11 commits January 11, 2026 19:16
Signed-off-by: Jonas Yang <joyang@nvidia.com>
Signed-off-by: Jonas Yang <joyang@nvidia.com>
Signed-off-by: Jonas Yang <joyang@nvidia.com>
Signed-off-by: Jonas Yang <joyang@nvidia.com>
Signed-off-by: Jonas Yang <joyang@nvidia.com>
Comment out e2e_grpo_trainer jobs in workflow
@hchings hchings force-pushed the hchings/fix-ppo-flow branch from b04560a to aafd494 Compare January 11, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants