Skip to content

Conversation

@chenjiaoAngel
Copy link
Contributor

@chenjiaoAngel chenjiaoAngel commented Jan 9, 2026

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

validate process and rollout process can be paralled in fully-async mode. This can reduce rollouter ilde and improve timing_s/gen speed when in short-long response_length case.

This is below profiler: (qwen2.5-Math-7b)

image image image image

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

we can use dapo_7b_math_fsdp2_8_8.sh, and add +async_training.parallel_validate_and_rollout=True command

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces parallel processing for validation in the FullyAsyncRollouter by using a ThreadPoolExecutor. This allows validation to run asynchronously, controlled by the parallel_validate_and_rollout configuration. The changes refactor the validation logic to support both synchronous and asynchronous execution paths. My review identifies a critical issue with unhandled exceptions in a fire-and-forget asyncio task, which could lead to silent failures. I have also pointed out several high-severity issues related to Python best practices, such as placing imports inside methods, accessing private attributes, using non-idiomatic boolean comparisons, and including non-English comments, all of which impact code quality and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant