Skip to content

Conversation

@JacobHelwig
Copy link
Contributor

Work in progress to extend VeOmni engine to RL training

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new installation script, install_veomni.sh, to set up the environment for the VeOmni RL Engine. The script is a good starting point, but I've identified a few critical issues related to its robustness and reliability. My feedback focuses on adding proper error handling to prevent partial installations, ensuring the script is idempotent so it can be run multiple times without manual intervention, and improving consistency in package management. Addressing these points will make the script more stable and user-friendly.

@JacobHelwig
Copy link
Contributor Author

Hi @A1waysBeenHere and @ji-huazhong. I’m planning to start extending the VeOmni engine from #4072 to RL training tomorrow and work on it over the next few days. Posting here to coordinate in case this overlaps with anything you’re already working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant