Skip to content

Conversation

@Annarine
Copy link
Contributor

@Annarine Annarine commented Jan 4, 2026

What does this PR do?

Fix the bug, some model need to do some work after update weights;
Example: Ascend DeepSeekV3 mla : after update weights should tranpose

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a call to process_weights_after_loading after updating weights for non-FP8 models. This appears to be an important bugfix. However, the same logic is missing for the FP8 model code path, which could lead to incorrect model behavior. I've added a critical comment to highlight this and recommend applying the fix to the FP8 path as well to ensure correctness for all model types.

Comment on lines 271 to 274
vllm_config = model_runner.vllm_config
device = next(model.parameters()).device
from vllm.model_executor.model_loader.utils import process_weights_after_loading
process_weights_after_loading(model, vllm_config, device)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The addition of process_weights_after_loading seems to be a necessary bugfix for correctly updating model weights. However, this logic is only applied to the non-FP8 code path. The FP8 path, handled in the if is_fp8_model(...) block (lines 263-267), also performs weight loading but misses this crucial post-processing step.

This omission could lead to incorrect behavior or bugs for FP8 models after weights are updated.

Please ensure process_weights_after_loading is also called for the FP8 model path. A possible solution is to duplicate these lines inside the if block, or refactor to call it once after the if-else statement.

@Annarine Annarine changed the title bugfix vllm-rollout update weights [rollout] bugfix vllm-rollout update weights Jan 5, 2026
@Annarine Annarine changed the title [rollout] bugfix vllm-rollout update weights [rollout] fix: vllm-rollout update weights Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant