Skip to content

Comments

Fix/filename length limit#211

Open
aeromomo wants to merge 2 commits intovolcengine:mainfrom
aeromomo:fix/filename-length-limit
Open

Fix/filename length limit#211
aeromomo wants to merge 2 commits intovolcengine:mainfrom
aeromomo:fix/filename-length-limit

Conversation

@aeromomo
Copy link
Contributor

Description

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

OpenClaw Integration added 2 commits February 18, 2026 14:45
Adds 30+ test cases covering:
- Long filename handling (boundary conditions at 255/256 bytes)
- Search edge cases (None guards, empty results, post-deletion)
- Duplicate file handling (case sensitivity, unicode normalization)
- Text compression edge cases (empty, emoji-only, 1MB, binary-like)
- Concurrent operation safety (20 parallel writes, mixed search/write)
- Unicode edge cases (zero-width, RTL, combining chars, surrogate pairs)
- Security (path traversal, null bytes, deeply nested JSON)

Includes both full test suite (test_edge_cases.py) for modern Python/async
and simplified version (test_edge_cases_simple.py) that runs on older Python.

These tests expose potential boundary conditions and race conditions that
might not be covered in regular testing. Some may fail on current codebase
- these highlight areas for improvement.
- Enforce 255-byte filename limit to prevent filesystem issues
- Truncate long filenames while preserving extensions
- Handle UTF-8 encoding properly for CJK characters
- Add proper logging for truncations

Fixes potential issues with very long filenames (>255 bytes) that could
cause filesystem errors on various platforms. The fix preserves file
extensions and handles multi-byte UTF-8 characters correctly.

Includes test demonstrating the fix works for:
- Exact 255-byte filenames (unchanged)
- 256+ byte filenames (truncated)
- CJK character filenames (proper UTF-8 handling)
- Filenames without extensions
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


OpenClaw Integration seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MaojiaSheng
Copy link
Collaborator

thanks, and please

  1. remove unneccesary unit tests
  2. organize code in openviking/parse/parsers/upload_utils.py better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants