add user guide from main repository#472
Conversation
Signed-off-by: Aniket <aniketchawardol@gmail.com>
|
Welcome @aniketchawardol! It looks like this is your first PR to volcano-sh/website 🎉 |
Summary of ChangesHello @aniketchawardol, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Volcano documentation by introducing a new, dedicated 'User Guide' chapter. It consolidates and expands user-focused content, making it easier for users to understand and configure various aspects of the Volcano scheduler and its plugins. The update also includes a detailed performance tuning guide and general improvements to content presentation and link integrity. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a substantial amount of user guide documentation by porting it from the main repository. The effort to consolidate and format this content is appreciated. However, the review has identified several issues that need addressing. There are critical errors in some YAML examples, such as typos in resource names, incorrect casing for kind, and the use of smart quotes, which will cause configurations to fail for users. Additionally, there are numerous formatting inconsistencies, including missing newlines at the end of files, improper use of HTML tags, and incorrect code block formatting. Several files also contain grammatical errors, typos, and misleading comments that reduce the clarity and professionalism of the documentation. Addressing these issues will significantly improve the quality and usability of the new user guide.
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the Volcano User Guide documentation from the main repository to the website, adding comprehensive user documentation for version 1.11.0. The changes include new user guide pages, formatting improvements, image additions, and fixes for broken links.
Changes:
- Added 25+ user guide documents covering various Volcano features including vGPU, vNPU, plugins, scheduling, and performance tuning
- Fixed broken installation guide links in GPU virtualization documentation
- Added network topology images and created a new "User Guide" navigation chapter
Reviewed changes
Copilot reviewed 29 out of 43 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| config/_default/menus.toml | Adds "User Guide" menu entry to documentation navigation |
| content/en/docs/user_guide.md | Index page listing all user guide topics |
| content/en/docs/user_guide_*.md | 25+ individual user guide documents for various Volcano features |
| content/en/docs/v1-11-0/gpu_virtualization.md | Fixed broken installation guide link |
| content/zh/docs/v1-11-0/gpu_virtualization.md | Fixed broken installation guide link (Chinese version) |
| static/img/network-topology/workload-deploy-example.png | Added network topology diagram image |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks! @aniketchawardol You did a great work, but you should sign off your commit to pass the DCO validation(use |
config/_default/menus.toml
Outdated
|
|
||
| [[docs]] | ||
| name = "User Guide" | ||
| weight = 9 |
There was a problem hiding this comment.
I prefer to place the user guide between the Key Features and Ecosystem sections (weight = 5), and adjust the weight of other sections accordingly.
There was a problem hiding this comment.
coming soon!
Oh I think I forgot to do it on 2nd commit |
Yes you should squash your commits and force push again maybe, the 2nd commit didn't be signed off |
Signed-off-by: Aniket <aniketchawardol@gmail.com>
fada526 to
abb9541
Compare
|
Wonderful! Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
/kind documentation
What this PR does / why we need it: This PR adds user-docs documentation from the main repository. All sections of user guide have been added and integrated with a dedicated User Guide Chapter. Conent has been formatted, images have been added, broken links have been fixed. (was searching for broken links and found that gpu-virtualization page also had broken installation guide links, updated them as well).
examples of formatting done:

Which issue(s) this PR fixes: #467
I think I was exceeding the limit for a manual review, hence I have currently added docs for the latest version only. User guides for older versions can be added later according to their compatibility.