[BugFix]: Remove leading zeros from dateday in TOML front matter#449
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @codeEvolveZenith345, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical compatibility issue preventing the use of newer Hugo versions for building blog posts. It standardizes the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the TOML front matter of several blog posts. The use of leading zeros for integer values like dateday is not compliant with the TOML v1.0.0 specification and was causing build failures with newer Hugo versions. The changes remove these leading zeros, ensuring the site can be built with modern tools. The fix is applied consistently across all relevant files. I've added one suggestion for a potential follow-up improvement to enhance maintainability by removing redundant date fields.
content/en/blog/Meet Cloud Native Batch Computing with Volcano in AI & Big Data Scenarios.md
Show resolved
Hide resolved
Removes leading zeros from dateday values to comply with TOML v1.0.0 specification. This change is backward compatible with Hugo v0.57.2 and prevents build failures when upgrading to modern Hugo versions. Leading zeros create ambiguity with octal notation and are rejected by Hugo v0.123.7+ and TOML parsers following v1.0.0 spec. Signed-off-by: Lakshya Saxena <suntiwari3495@gmail.com>
6a3cf97 to
bae9053
Compare
|
/cc @Arhell Apologies for bothering you, but could you please review->approve this minimal bug fix? |
This bug caused hugo to crash on local development. |
The thing is that site runs on Hugo version 0.57.0. I have tested the build on that version of Hugo and the build completed without errors. |
I think the behavior must be uniform. If it is in all other occurrences/instances, it should be replicated/made uniform. That is the motive of this PR, to make the contributors test changes with ease! |
|
/cc @JesseStutler Please review/approve! |
Description
Removes leading zeros from
datedayvalues in blog post TOML front matter to comply with TOML v1.0.0 specification.Why This Change is Needed
The Problem:
dateday = 01,dateday = 07etc. in TOML front matterError: unmarshal failed: toml: expected newlineThe Fix:
dateday = 07→dateday = 7(remove leading zeros)Checklist
Type of Change
/kind bug
Which Issue(s) This PR Fixes
Fixes #448