✨feat: introduce python linting in agentcode by katara-Jayprakash · Pull Request #121 · volcano-sh/agentcube

katara-Jayprakash · 2026-01-07T03:40:14Z

introduce python linting in agent code
fix's the part of:#81

gemini-code-assist · 2026-01-07T03:40:19Z

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

acsoto · 2026-01-07T03:41:34Z

#95

codecov-commenter · 2026-01-07T03:47:40Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@f0cebc3). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage        ?   29.20%           
=======================================
  Files           ?       28           
  Lines           ?     2551           
  Branches        ?        0           
=======================================
  Hits            ?      745           
  Misses          ?     1690           
  Partials        ?      116

Flag	Coverage Δ
unittests	`29.20% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

katara-Jayprakash · 2026-01-07T03:50:07Z

#95

ouch! sorry sir , but you did not assign the epic so I thought it was free to work, or may be it was me who did not see the other open issue

acsoto · 2026-01-07T06:39:17Z

#95

ouch! sorry sir , but you did not assign the epic so I thought it was free to work, or may be it was me who did not see the other open issue

It's all good! I just wanted to point it out so we don't have duplicate efforts. Thanks for your contribution

hzxuzhonghu

@LiZhenCheng9527 we should use ruff, which seems more widely used

hzxuzhonghu · 2026-01-09T07:56:30Z

.github/workflows/python-lint.yml

+  pull_request:
+    branches:
+      - main
+      - release


Suggested change

- release

- release-*

added this in next commit, i should be more focused

hzxuzhonghu · 2026-01-09T07:56:55Z

.github/workflows/python-lint.yml

+      - "**.py"
+      - "cmd/cli/pyproject.toml"
+      - "sdk-python/pyproject.toml"
+  push:


no need add this trigger, this means it is merged

ya thats actually make sense, we did not need to check the linting after pr merged.

hzxuzhonghu · 2026-01-12T09:13:07Z

.github/workflows/python-lint.yml

+          python-version: "3.10"
+      - name: Run Lint
+        run: |
+          make lint-python


I can not find this command in Makefile

ya i try to write it myself but fails, so shift to writing into the workflow

katara-Jayprakash · 2026-01-12T16:42:42Z

Makefile

 lint: golangci-lint ## Run golangci-lint
 	$(GOLANGCI_LINT) run ./...

+.PHONY: lint-python


why this doesn't work here? just curious it fail with gen-check all

.github/workflows/python-lint.yml

hzxuzhonghu · 2026-01-14T02:49:54Z

@acsoto Please take a look at the python change

acsoto · 2026-01-15T11:20:36Z

https://github.com/katara-Jayprakash/agentcube/blob/python-linting/example/pcap-analyzer/pcap_analyzer.py

https://github.com/volcano-sh/agentcube/blob/main/example/pcap-analyzer/pcap_analyzer.py

hzxuzhonghu · 2026-01-16T06:55:55Z

example/pcap-analyzer/pcap_analyzer.py


-# Sandbox / CodeInterpreter configuration
-CODEINTERPRETER_NAME = os.environ.get("CODEINTERPRETER_NAME", "simple-codeinterpreter")
-SANDBOX_NAMESPACE = os.environ.get("SANDBOX_NAMESPACE", "default")


why not allow customize namespace?

example/pcap-analyzer/pcap_analyzer.py

fixing things

volcano-sh-bot · 2026-01-16T15:45:25Z

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

- Add GitHub workflow for Python linting using Ruff - Fix import ordering and formatting issues Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

katara-Jayprakash · 2026-01-16T15:58:12Z

/cc @acsoto @hzxuzhonghu finally done! review and merge it sir!

acsoto · 2026-01-19T01:37:48Z

/lgtm

volcano-sh-bot · 2026-01-19T01:37:51Z

@acsoto: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

katara-Jayprakash · 2026-01-19T01:40:43Z

/lgtm

thanx so we can merge it now?

hzxuzhonghu · 2026-01-19T03:30:38Z

/lgtm

hzxuzhonghu · 2026-01-19T03:31:27Z

/hold cancel

katara-Jayprakash · 2026-01-19T08:14:45Z

thanx sir,✨

volcano-sh-bot added the size/M label Jan 7, 2026

katara-Jayprakash mentioned this pull request Jan 7, 2026

[workflow] Build Agentcube Community Infra #81

Closed

7 tasks

katara-Jayprakash mentioned this pull request Jan 7, 2026

Ensuring the quality of Python code merged into the main branch #63

Closed

volcano-sh-bot requested a review from LiZhenCheng9527 January 7, 2026 07:47

hzxuzhonghu reviewed Jan 8, 2026

View reviewed changes

katara-Jayprakash force-pushed the python-linting branch from 6731f32 to e4d4053 Compare January 9, 2026 04:17

hzxuzhonghu reviewed Jan 9, 2026

View reviewed changes

volcano-sh-bot added size/S and removed size/M labels Jan 9, 2026

hzxuzhonghu reviewed Jan 12, 2026

View reviewed changes

volcano-sh-bot added size/M size/S and removed size/S size/M labels Jan 12, 2026

katara-Jayprakash commented Jan 12, 2026

View reviewed changes

hzxuzhonghu reviewed Jan 13, 2026

View reviewed changes

.github/workflows/python-lint.yml Show resolved Hide resolved

volcano-sh-bot added size/M size/L and removed size/S size/M labels Jan 13, 2026

katara-Jayprakash force-pushed the python-linting branch from c940f4f to 301613d Compare January 13, 2026 13:39

katara-Jayprakash requested a review from hzxuzhonghu January 13, 2026 13:50

hzxuzhonghu requested a review from Copilot January 14, 2026 02:50

hzxuzhonghu reviewed Jan 16, 2026

View reviewed changes

example/pcap-analyzer/pcap_analyzer.py Outdated Show resolved Hide resolved

katara-Jayprakash requested a review from acsoto January 16, 2026 07:14

katara-Jayprakash force-pushed the python-linting branch from 9e72dab to 16d5e01 Compare January 16, 2026 15:23

volcano-sh-bot added size/XXL and removed size/L labels Jan 16, 2026

katara-Jayprakash closed this Jan 16, 2026

Merge remote-tracking branch 'upstream/main'

bd1a240

fixing things

katara-Jayprakash reopened this Jan 16, 2026

katara-Jayprakash force-pushed the python-linting branch from 16d5e01 to 3f664ce Compare January 16, 2026 15:45

volcano-sh-bot added the do-not-merge/contains-merge-commits label Jan 16, 2026

volcano-sh-bot added size/XL and removed size/XXL labels Jan 16, 2026

Add Python linting with Ruff

33d3a16

- Add GitHub workflow for Python linting using Ruff - Fix import ordering and formatting issues Signed-off-by: katara-Jayprakash <katarajayprakash@icloud.com>

katara-Jayprakash force-pushed the python-linting branch from 3f664ce to 33d3a16 Compare January 16, 2026 15:55

volcano-sh-bot added size/L and removed size/XL labels Jan 16, 2026

katara-Jayprakash requested a review from hzxuzhonghu January 16, 2026 15:56

volcano-sh-bot added the lgtm label Jan 19, 2026

volcano-sh-bot removed the do-not-merge/hold label Jan 19, 2026

volcano-sh-bot merged commit 7637e5f into volcano-sh:main Jan 19, 2026
12 checks passed

Conversation

katara-Jayprakash commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 7, 2026

Uh oh!

acsoto commented Jan 7, 2026

Uh oh!

codecov-commenter commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

katara-Jayprakash commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acsoto commented Jan 7, 2026

Uh oh!

hzxuzhonghu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hzxuzhonghu commented Jan 14, 2026

Uh oh!

acsoto commented Jan 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

volcano-sh-bot commented Jan 16, 2026

Uh oh!

katara-Jayprakash commented Jan 16, 2026

Uh oh!

acsoto commented Jan 19, 2026

Uh oh!

volcano-sh-bot commented Jan 19, 2026

Uh oh!

katara-Jayprakash commented Jan 19, 2026

Uh oh!

hzxuzhonghu commented Jan 19, 2026

Uh oh!

hzxuzhonghu commented Jan 19, 2026

Uh oh!

Uh oh!

katara-Jayprakash commented Jan 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

katara-Jayprakash commented Jan 7, 2026 •

edited

Loading

codecov-commenter commented Jan 7, 2026 •

edited

Loading

katara-Jayprakash commented Jan 7, 2026 •

edited

Loading