Don't double-eval quoted params (fixes #13)#15
Merged
vokimon merged 2 commits intovokimon:masterfrom Dec 11, 2025
Merged
Conversation
Owner
|
Could you, please, propose a unit test to illustrate the test case? |
Contributor
Author
|
I didn't realize you were running test cases. It looks like many of the test cases here are already failing: Let me see about adding a new case to cover this fix. |
Contributor
Author
|
I have pushed exactly the error case I described in #13 as a test case. It fails in 1.5.3 but passes with this fix. |
Owner
|
Now, all tests are passing in master. Could you rebase your branch? |
Contributor
Author
|
You should have full permission to push changes to this branch, but I will run a rebase. |
c33c09f to
13ec7da
Compare
Owner
|
The error is another fragile test of mine depending on external services. Let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the code redefines
param, without the elif here this block can run on an empty param string, incorrectly runningevaltwice:This patch fixes the bug.